Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep search field in Select focused #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maximgrs
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boemly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 9:10am

Copy link

github-actions bot commented Jan 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/boemly.cjs.production.min.js 1.56 MB (0%) 32 s (0%) 1.5 s (+6.15% 🔺) 33.4 s
dist/boemly.esm.js 71.86 KB (0%) 1.5 s (0%) 217 ms (+37.15% 🔺) 1.7 s

@lialila
Copy link
Contributor

lialila commented Jan 30, 2025

I tested it the pack of boemly in the app and this makes the Select dropdown jump up to the search input field and doesn't allow the user to scroll the select dropdown.

@maximgrs maximgrs force-pushed the mg/fix-select-search-focus branch from ba10184 to 014963d Compare January 30, 2025 09:08
@maximgrs
Copy link
Contributor Author

I tested it the pack of boemly in the app and this makes the Select dropdown jump up to the search input field and doesn't allow the user to scroll the select dropdown.

I tried to prevent the input from losing focus when the mouse hovers over an option, but I think it's not necessary because it also causes the select dropdown to jump back up to the search input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants